conio <conio.h+bugs.python....@gmail.com> added the comment:
Thank you very much, Steve. I took a look but didn't get to making the patch. I'm happy to see it was just removing the calculation of the PF(ARM) folder. For the second issue, even though I prefer it the way I said (unqualified = native), since (i) the default is using the value of `sys.winver` at the end of the path, and it's "VER" for amd64 Python and "VER-32" for x86 Python regardless of the OS (i.e. even on 32-bit Windows); (ii) this has been the situation long enough to be a compatibility concern as you said, and (iii) if someone really wants the names to be the other way around they may choose whatever they like during the install, and it's only the defaults that are that way I think you are right in keeping it out for now. I wouldn't insist on it. If there comes a time when more arguments in favor of this change come up or the circumstances change (e.g. the compatibility issue becomes less of a concern) I'm sure you'd revisit this. I did notice one small issue when I tried to build Python for ARM64 following your message from 2022-02-15. The help message for `Tools/msi/build.bat` says to use the `-ARM64` flag to build installers for ARM64 but it didn't work for me. I took me a few attempts at clean and rebuild before I finally looked at the script itself and saw that it actually expects `-arm64` in lowercase. If you could change either the help string or the flag itself so they'd math it would be great. Uppercase is nice because it is consistent with `PCbuild/build.bat` and lowercase is nice because if there's come CI that uses this flag it wouldn't have to be modified too. Obviously you if there are such consideration better than me so I leave the decision to you. If there's no problem or difficulty in changing the arguments for `Tools/msi/build.bat` it might be nice if building for ARM64 would be "-ARM64" and building for x86 would be "-Win32" to match the platform names for `PCbuild/build.bat`. ---------- _______________________________________ Python tracker <rep...@bugs.python.org> <https://bugs.python.org/issue46744> _______________________________________ _______________________________________________ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com