STINNER Victor <victor.stin...@haypocalc.com> added the comment:

amaury> The patch is fine.

Cool :-) Anyone to commit the fix? Maybe, tarek?

amaury> If it were me, I'd change os.walk to accept 
amaury> keyword-only arguments:
amaury> def walk(top, *, topdown=True, onerror=None,
amaury>          followlinks=False):
amaury>          ...

I like the idea but it should be proposed in a new issue :-) I 
proposed an API change for open() (issue #4121) but it was rejected by 
Guido:

"(...) Beyond 3.0, I'm still rather reluctant -- I expect most users 
will be wise and use keyword args anyway; I'm not sure what we buy by 
forcing this. (...)"

But walk() is a different case than open().

----------
nosy: +tarek

_______________________________________
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue4601>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

Reply via email to