Mark Dickinson <dicki...@gmail.com> added the comment: Thanks! Committed your patch in r70497.
I think _PY_STRUCT_RANGE_CHECKING can also be removed from the module and the tests (treated as though it's 1 throughout). In theory there could be people using it, but it's not documented and the leading underscore in the name clearly indicates that its supposed to be private, so I think it's safe to remove. It looks like it was there just to enable some extra tests (tests that were broken with earlier versions of the struct module thanks to struct bugs). I agree that we should bump the version number once we're done here. I really appreciate this work: the struct module has been in need of cleanup for a while. Thank you again. ---------- _______________________________________ Python tracker <rep...@bugs.python.org> <http://bugs.python.org/issue5463> _______________________________________ _______________________________________________ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com