STINNER Victor <vstin...@python.org> added the comment:
> bpo-45187: Collect test_socket tests using unittest (GH-28317) Nice enhancement! Thanks. > self.addCleanup(thread.join, self.timeout) I suggest to use test.support.threading_helper.join_thread() to avoid blocking if the thread raises an exception or never completes. The function has a timeout with a reasonable default value (adapted per buildbot). ---------- nosy: +vstinner _______________________________________ Python tracker <rep...@bugs.python.org> <https://bugs.python.org/issue45187> _______________________________________ _______________________________________________ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com