[issue5420] Queue deprecation warning patch

[Tennessee Leeuwenburg]

Tennessee Leeuwenburg <tleeuwenb...@gmail.com> added the comment:

Hi JP,

I experimented with stacklevel but to be honest nothing I saw appeared
greatly more useful than the default for the tests in question.

What form would the unit tests take? Trying to assert that empty() and
full() raised a deprecation warning? I'm not sure how I would go about that,
but I'll see what I can do.

Thanks,
-Tennessee

On Thu, Mar 5, 2009 at 3:00 PM, Jean-Paul Calderone
<rep...@bugs.python.org>wrote:

>
> Jean-Paul Calderone <exar...@divmod.com> added the comment:
>
> Unit tests are a great thing as well.  Also, the deprecation warnings
> you've added are the really annoying kind.  They refer to users to the
> source of the deprecated methods themselves!  A vastly preferable use of
> the warnings system is to refer users to the *callers* of the deprecated
> methods.  Try passing different values for the stacklevel parameter of
> the warnings.warn function until you get a warning that is more helpful.
>
> ----------
> nosy: +exarkun
>
> _______________________________________
> Python tracker <rep...@bugs.python.org>
> <http://bugs.python.org/issue5420>
> _______________________________________
>

Added file: http://bugs.python.org/file13252/unnamed

_______________________________________
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue5420>
_______________________________________
Hi JP,<br><br>I experimented with stacklevel but to be honest nothing I saw 
appeared greatly more useful than the default for the tests in 
question.<br><br>What form would the unit tests take? Trying to assert that 
empty() and full() raised a deprecation warning? I&#39;m not sure how I would 
go about that, but I&#39;ll see what I can do.<br>
<br>Thanks,<br>-Tennessee<br><br><div class="gmail_quote">On Thu, Mar 5, 2009 
at 3:00 PM, Jean-Paul Calderone <span dir="ltr">&lt;<a 
href="mailto:rep...@bugs.python.org";>rep...@bugs.python.org</a>&gt;</span> 
wrote:<br><blockquote class="gmail_quote" style="border-left: 1px solid 
rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
<br>
Jean-Paul Calderone &lt;<a 
href="mailto:exar...@divmod.com";>exar...@divmod.com</a>&gt; added the 
comment:<br>
<br>
Unit tests are a great thing as well.  Also, the deprecation warnings<br>
you&#39;ve added are the really annoying kind.  They refer to users to the<br>
source of the deprecated methods themselves!  A vastly preferable use of<br>
the warnings system is to refer users to the *callers* of the deprecated<br>
methods.  Try passing different values for the stacklevel parameter of<br>
the warnings.warn function until you get a warning that is more helpful.<br>
<br>
----------<br>
nosy: +exarkun<br>
<div><div></div><div class="h5"><br>
_______________________________________<br>
Python tracker &lt;<a 
href="mailto:rep...@bugs.python.org";>rep...@bugs.python.org</a>&gt;<br>
&lt;<a href="http://bugs.python.org/issue5420"; 
target="_blank">http://bugs.python.org/issue5420</a>&gt;<br>
_______________________________________<br>
</div></div></blockquote></div><br><br clear="all"><br>-- 
<br>--------------------------------------------------<br>Tennessee 
Leeuwenburg<br><a 
href="http://myownhat.blogspot.com/";>http://myownhat.blogspot.com/</a><br>&quot;Don&#39;t
 believe everything you think&quot;<br>


_______________________________________________
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com