Marc-Andre Lemburg <m...@egenix.com> added the comment: On 2009-02-24 20:39, Mark Dickinson wrote: > Mark Dickinson <dicki...@gmail.com> added the comment: > > Updated Victor's patch: > > - applies cleanly against newly whitespace-normalized unicodeobject.c > - renamed USE_WCHAR_SURROGATE to CONVERT_WCHAR_TO_SURROGATES > - add defined(SIZEOF_WCHAR_T) check > > I find the patched version of PyUnicode_FromWideChar quite hard to follow > with all the #ifdefery. I wonder whether it might be better to define a > _PyUnicode16_FromWideChar32 helper function instead.
Same here. It would be better to have a single #ifdef #else #endif block with one branch for the CONVERT_WCHAR_TO_SURROGATES case and the other for the normal operation. No need for a new helper function. _______________________________________ Python tracker <rep...@bugs.python.org> <http://bugs.python.org/issue4474> _______________________________________ _______________________________________________ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
