Quentin Pradet <quentin.pra...@gmail.com> added the comment: Thank you for the quick fix! 🙏 Both the reproducer and the urllib3 test suite run fine with this change.
However, we can't trust `HAS_NEVER_CHECK_COMMON_NAME` anymore, because it will be True in Python versions where `hostname_checks_common_name` does not work. Is it possible to have, uh, `REALLY_HAS_NEVER_CHECK_COMMON_NAME_I_PROMISE` or something like that? :D It could even be private. Otherwise, we will only be able to use `hostname_checks_common_name` in Python 3.10.0a7+. ---------- _______________________________________ Python tracker <rep...@bugs.python.org> <https://bugs.python.org/issue43522> _______________________________________ _______________________________________________ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
