Terry J. Reedy <tjre...@udel.edu> added the comment:

I changed the title to what a PR/commit title should look like.  Your 
justification is that "Multiple writes possibly cause excessive network usage 
and increased implementation complexity on the other end."

I see no problem with the formatting of your first post.

I presume the proposal is to make a list of bytes and then b''.join(the_list).  
This is now a standard idiom.  Have you tested a patch locally?  Can you make a 
PR?

I don't know if there was a particular reason to not join before sending.  
Perhaps because successive sends effectively do the same thing, though with the 
possible  downsides you note.  I am not an expert on network usage.

The _connect method was added by Senthil Kumaran in 2009 in #1424152 and 
revised since.  There is no current http maintainer, so I added as nosy  
Senthil and others who have worked on the module.

----------
nosy: +berker.peksag, gregory.p.smith, orsenthil, terry.reedy
title: http/client.py: - uses multiple network writes, possibly causing 
excessive network usage and increased implementation complexity on the other 
end -> Make http.client._tunnel send one byte string over the network

_______________________________________
Python tracker <rep...@bugs.python.org>
<https://bugs.python.org/issue43332>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

Reply via email to