STINNER Victor <vstin...@python.org> added the comment:
> Following https://bugs.python.org/issue42262, I think it'd be nice to convert > existing C code to use the more concise Py_NewRef() and Py_XNewRef() where > possible. Increases readability and less bug prone. In general, we don't accept changes which are only coding style changes. I don't see how Py_NewRef() or Py_XNewRef() is less error prone. In my experience, any change is more likely to introduce new bugs than leaving the code unchanged. See https://github.com/python/cpython/pull/23170 for a concrete case of a PR which converts code to Py_NewRef() / Py_XNewRef(): the PR introduced bugs (in early versions of the PR). ---------- _______________________________________ Python tracker <rep...@bugs.python.org> <https://bugs.python.org/issue42287> _______________________________________ _______________________________________________ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
