Irit Katriel <iritkatr...@yahoo.com> added the comment:

I'm not sure my patch completely resolved this issue. I'm adding Antoine re the 
OP's question about the assertLogs API. 

> Doing so would make the test over-specific and fragile.  The requirement is > 
> that a warning be logged, not that a specific logger issue the warning.

My view is that your test is fragile because it just asks "was anything logged" 
without checking the log message. The docs show how to verify that the log 
message is what you expect it to be.

----------
nosy: +pitrou

_______________________________________
Python tracker <rep...@bugs.python.org>
<https://bugs.python.org/issue41898>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

Reply via email to