Chris Withers <ch...@withers.org> added the comment:

Hmm, the more we get into this, the less comfortable I am of the patch in the 
PR.

Instead of copying and pasting more code that's likely to get out of sync, 
could you change the PR to just replace _importer with the correct parts of 
importlib to support your usecase?

Keep the unit test though, useful to show in mock why the change is needed, and 
make sure we do something sensible in the backport!

----------

_______________________________________
Python tracker <rep...@bugs.python.org>
<https://bugs.python.org/issue39551>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

Reply via email to