STINNER Victor <victor.stin...@haypocalc.com> added the comment: Comment about issue3826_gps05.diff: - I don't like "magical" attributes (sometimes it does exist, sometimes not) even if it's a protected attribute (_sock) => use self._sock=None? - fileno() returns a fixed value whereas the socket.fileno() returns -1 when the socket is closed => returns -1 or raise an error if the socket is closed? - I'm not sure that your test is really working: read a closed socket may raise an error because of the test on self._closed, not because the low level socket is closed => use fileno() to check if the socket is closed or not
_______________________________________ Python tracker <rep...@bugs.python.org> <http://bugs.python.org/issue3826> _______________________________________ _______________________________________________ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
