New submission from Serhiy Storchaka <storchaka+cpyt...@gmail.com>:
If __all__ is not defined in a module "from module import *" will import all keys from module.__dict__ which does not start with underscore. It can add undesired names to the current namespace. The common case is related to importing modules. 1. Importing modules which are imported in the original module for internal use. Every module usually imports several other modules, and since public module names are not underscored, they pollute the namespace of the module. To prevent leaking they names you need to import them under underscored name, like "import sys as _sys" (if you don't want to use __all__). This is cumbersome and makes the module code less readable. 2. Importing submodules. The problem is that the result depends on the history of imports. If you imported "module.submodule" before or if it was imported implicitly by other module, "from module import *" will import the "submodule" name. But if it was not imported before, "from module import *" will import the "submodule" name. The proposed PR excludes modules from importing by star-import if __all__ is not defined. Discussion on Python-ideas: https://mail.python.org/archives/list/python-id...@python.org/thread/AKWL7CRCCFACSITAH2NNFBL5BGRKLKJD/ ---------- components: Interpreter Core messages: 352736 nosy: gvanrossum, serhiy.storchaka priority: normal severity: normal status: open title: Do not import modules in star-import when __all__ is not defined. type: enhancement versions: Python 3.9 _______________________________________ Python tracker <rep...@bugs.python.org> <https://bugs.python.org/issue38215> _______________________________________ _______________________________________________ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
