Samuel Freilich <sfreil...@google.com> added the comment:

This is still not totally fixed. This solves the underlying error with method 
specs, but not the bug that was causing the error-swallowing in 
assert_has_calls:

https://github.com/python/cpython/blob/ee536b2020b1f0baad1286dbd4345e13870324af/Lib/unittest/mock.py#L2216

expected = [self._call_matcher(c) for c in calls]
cause = expected if isinstance(expected, Exception) else None

isinstance(expected, Exception) is never true, because expected is always a 
list. It should instead be:

cause = next((e for e in expected if isinstance(e, Exception)), None)

----------
nosy: +sfreilich

_______________________________________
Python tracker <rep...@bugs.python.org>
<https://bugs.python.org/issue36871>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

Reply via email to