aeros167 <aeros...@gmail.com> added the comment:

> Thanks for the PR, aeros167! BTW, if you want to open a new issue and 
> modernize the tests to use importlib directly that would be great!

Sounds good, I'll definitely look into doing that after finishing up this 
issue. Was waiting the previous PR to be merged before replacing the deprecated 
method "random.choose" with "random.choice" in "test_pkg_import.py" and then 
also moving the other two into test_importlib. 

Thank you very much for the timely feedback. This has been a great experience 
for learning to contribute to larger open source projects. It's been an 
aspiration of mine to give back to Python, as it was my first serious 
programming language 5 years ago. This may be an incredibly minor contribution 
in the grand scheme of things, but my goal is for it to be the first of many (:

----------

_______________________________________
Python tracker <rep...@bugs.python.org>
<https://bugs.python.org/issue19696>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

Reply via email to