New submission from Jakub Kulik <kulik...@gmail.com>:
Hi, We have several tests failing on Solaris due to the slightly different behavior of os.sendfile function. Sendfile on Solaris can raise EINVAL if offset is equal or bigger than the size of the file (Python expects that it will return 0 bytes sent in that case). I managed to patch `socked.py` with additional checks on two places (patch attached), Python 3.8 introduced sendfile in shutil.py module, where I don't have fsize variable so easily accessible and so I am unsure what to do with it. Also, I am not even sure if this is a correct way to handle this. Maybe this should be patched somewhere in the .c file? Or there might be other systems with the same behavior and all I need to do is adjust some define guards there... EINVAL can also mean other things and so I guess I cannot just catch that errno and continue as with returned 0. Thanks ---------- components: Library (Lib) files: sendfile.patch keywords: patch messages: 340017 nosy: kulikjak priority: normal severity: normal status: open title: os.sendfile can return EINVAL on Solaris type: crash versions: Python 3.7, Python 3.8 Added file: https://bugs.python.org/file48262/sendfile.patch _______________________________________ Python tracker <rep...@bugs.python.org> <https://bugs.python.org/issue36610> _______________________________________ _______________________________________________ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
