Raymond Hettinger <raymond.hettin...@gmail.com> added the comment:

In general, deferred imports are code smell that should avoided unless really 
necessary. They create an on-going maintenance burden (there's a reason most 
modules don't do this and put their imports at the top).

FWIW, a broken hashlib is a localized bug, not an optimization problem. It 
doesn't affect any user with a build that passes the test suite.

Running "python -v" shows that "random" is not part of the normal startup, so 
deferring the import saves zero for normal startup. It only affects modules 
that specifically import random.

IIRC, Mercurial uses hashing extensively, so deferring the import doesn't help 
them at all.

This is minor change, so I suppose we could let it go through; however, it 
seems somewhat arbitrary and the reasons offered seem dubious. For the most 
part, it isn't a good practice.

----------

_______________________________________
Python tracker <rep...@bugs.python.org>
<https://bugs.python.org/issue36559>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

Reply via email to