Gregory P. Smith <[EMAIL PROTECTED]> added the comment: Alright I've taken another fresh look at this. I understand the dup semantics issue and don't want to break that.
Attached are two patches, either one of these will fix the problem and breakage.py test code attached to this bug. Personally I prefer the socket.py patch as I think it will solve this problem in other places it could potentially pop up. It calls self._sock._decref_socketios() from within the SocketIO.close() method so that after a SocketIO returned by socket.makefile() is closed, it will no longer prevent the underlying socket from closing. The socketserver.py patch also works but seems like more of a hack as it is still relies on immediate reference counted destruction. Please review. I'm guessing its too late in the release candidate process for 3.0 to get this in, but we should do it for 3.0.1. _______________________________________ Python tracker <[EMAIL PROTECTED]> <http://bugs.python.org/issue3826> _______________________________________ _______________________________________________ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
