Brett Cannon <[EMAIL PROTECTED]> added the comment:

And it turns out I should have looked at the other patch instead. =)

The missing comment from the test still holds. I also think you did not
need to cut out the fast path from translate as much as you did when
there is no deletion. It's still legitimate to goto 'done' if you put
back the work being done in the 'if' statement. You can see my attached
patch to see what I mean.

Otherwise it looks good.

Added file: http://bugs.python.org/file12065/issue4348.diff

_______________________________________
Python tracker <[EMAIL PROTECTED]>
<http://bugs.python.org/issue4348>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

Reply via email to