New submission from Karthikeyan Singaravelan <tir.kar...@gmail.com>:
Currently, assert_called_with has expected calls list in the same line with AssertionError that causes the visualizing the difference to be hard. It will be great if Expected call occurs on the next line so that the diff is improved. The change has to be made at https://github.com/python/cpython/blob/f8e9bd568adf85c1e4aea1dda542a96b027797e2/Lib/unittest/mock.py#L749 . from unittest import mock m = mock.Mock() m(1, 2) m.assert_called_with(2, 3) Current output : Traceback (most recent call last): File "/tmp/bar.py", line 5, in <module> m.assert_called_with(2, 3) File "/Library/Frameworks/Python.framework/Versions/3.7/lib/python3.7/unittest/mock.py", line 820, in assert_called_with raise AssertionError(_error_message()) from cause AssertionError: Expected call: mock(2, 3) Actual call: mock(1, 2) Proposed output : Traceback (most recent call last): File "/tmp/bar.py", line 5, in <module> m.assert_called_with(2, 3) File "/Users/karthikeyansingaravelan/stuff/python/cpython/Lib/unittest/mock.py", line 827, in assert_called_with raise AssertionError(_error_message()) from cause AssertionError: Expected call: mock(2, 3) Actual call: mock(1, 2) Some more alignment with the call list starting in the same column AssertionError: Expected call: mock(2, 3) Actual call: mock(1, 2) Originally reported in the GitHub repo at https://github.com/testing-cabal/mock/issues/424 . PR for this was closed since GitHub is used only for backporting (https://github.com/testing-cabal/mock/pull/425). I thought to report it here for discussion. Currently call list output is as per proposed output. AssertionError: Calls not found. Expected: [call(1, 2, 3)] Actual: [call(1, 2)]. ---------- components: Library (Lib) messages: 331849 nosy: cjw296, mariocj89, michael.foord, xtreak priority: normal severity: normal status: open title: Align expected and actual calls on mock.assert_called_with error message type: enhancement versions: Python 3.8 _______________________________________ Python tracker <rep...@bugs.python.org> <https://bugs.python.org/issue35500> _______________________________________ _______________________________________________ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
