Martin Panter <vadmium...@gmail.com> added the comment:
If something like your “addbuffer” method existed, then you won’t need to get
the size first, right? We don’t need the changes in “gettarinfo” for
“addbuffer” to be useful.
BTW have you considered returning a file writer rather than accepting a file
reader? Similar to ZipFile.open(..., mode='w'). It would be a bit more
complicated to implement, but also more flexible for the user:
# File downloaded with “urlopen”, also possible with TarFile.addbuffer API:
with tf.get_file_writer(download_tarinfo) as writer:
shutil.copyfileobj(urlopen_response, writer)
# SVG file generated on the fly, encoded with UTF-8 and Gzip compressed; not
possible with “addbuffer”:
writer = tf.get_file_writer(svgz_tarinfo)
gzip_writer = gzip.GzipFile(fileobj=writer, mode='w')
with io.TextIOWrapper(gzip_writer, 'utf-8') as text_writer:
svg = xml.sax.saxutils.XMLGenerator(text_writer, 'UTF-8')
svg.startDocument()
...
----------
_______________________________________
Python tracker <rep...@bugs.python.org>
<https://bugs.python.org/issue35227>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe:
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
