New submission from jcc2220 <jcc2...@columbia.edu>:
When _max_size is set to 0, the _check method will never call rollover, as the conditional for a rollover is never satisfied. However, in the truncate method, the _max_size is not checked against 0, and so a rollover could be called when it is 0. This is more of an issue of consistency - should 0 mean that it will never rollover? If so, truncate should be modified. Should 0 be interpreted as 'always rollover'? If so, the _check should be modified. Personally, I'd rather have something like -1 mean never, 0 mean always, and >0 mean only when greater than specified size. John ---------- components: Library (Lib) messages: 323809 nosy: jcc2220 priority: normal severity: normal status: open title: ambiguous _max_size parameter in SpooledTemporaryFile type: behavior versions: Python 3.7 _______________________________________ Python tracker <rep...@bugs.python.org> <https://bugs.python.org/issue34446> _______________________________________ _______________________________________________ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
