R. David Murray <rdmur...@bitdance.com> added the comment:
Conrad: thanks for the effort, but using f-strings with logging is counterproductive. The idea behind logging is that the logged strings are not materialized unless something actually wants to output them. Using fstrings means you are doing all the work of formatting the string regardless of whether or not the string is actually going to get written anywhere. The original patch also retains the debug guards that minimize overhead when debugging is not turned on, which it doesn't look like your patch does. Regardless, what we need at this stage is a github PR, not a patch :) ---------- _______________________________________ Python tracker <rep...@bugs.python.org> <https://bugs.python.org/issue24255> _______________________________________ _______________________________________________ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
