Martin v. Löwis <[EMAIL PROTECTED]> added the comment: > Most (or all) patches include new tests about bytes. Here is a patch for > os.rst documentation about listdir(), getcwdb() and readlink().
Thanks! Committed as r66829. I've added additional documentation in r66830, which should complete Guido's list of things to be documented. So the issue can be closed now. >> See msg74271 for what Guido considers the lacking documentation; >> you may find that other aspects also need documentation. > > I wrote a long document about bytes for filenames but not only. I'm still > waiting for some contributors or reviewers: > http://wiki.python.org/moin/Python3UnicodeDecodeError We should discuss that on python-dev, of course - the question is whether additional documentation patches are needed in response to this specific change. >> As for test cases: it seems that those got waived, in the hurry. > > Can you be more precise? Which tests have to be improved/rewritten? I was probably looking at the wrong patches (such as getcwd_bytes.patch, merge_os_getcwd_getcwdu.patch, etc); I now see that the final patch did have tests. I recommend that patches that get superseded by other patches are removed from the issue. The won't be deleted; it's still possible to navigate to them through the History at the bottom of the issue. _______________________________________ Python tracker <[EMAIL PROTECTED]> <http://bugs.python.org/issue3187> _______________________________________ _______________________________________________ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
