Berker Peksag <berker.pek...@gmail.com> added the comment:
I agree with Xavier's comment, but I've bitten by this before so I think it
would be better if we add more common arguments to the subprocess.run()
signature.
Adding **kwargs wouldn't be entirely correct since subprocess.run() doesn't
pass all its arguments to subprocess.Popen().
Let's add 'env=None' to the signature of subprocess.run():
.. function:: run(args, *, stdin=None, input=None, stdout=None, stderr=None,\
shell=False, cwd=None, timeout=None, check=False, \
encoding=None, errors=None, text=None)
https://github.com/python/cpython/blob/3055c947f98a078bd10d6a8cc352048a1b771d60/Doc/library/subprocess.rst#using-the-modsubprocess-module
----------
keywords: +easy
nosy: +berker.peksag
stage: -> needs patch
type: -> enhancement
versions: +Python 3.6, Python 3.8
_______________________________________
Python tracker <rep...@bugs.python.org>
<https://bugs.python.org/issue32392>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe:
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
