New submission from Daehee Kim <zsalad...@gmail.com>:
There's a proposal for a fix inconsistency of logger mechanism.
See below.
Example 1.
---------------------------------------------------
import logging
app_logger = logging.getLogger('app')
app_logger.error('foo')
logging.error('goo')
app_logger.error('foo')
---------------------------------------------------
result:
foo
ERROR:root:goo
ERROR:app:foo
---------------------------------------------------
You can see the inconsistency of app_logger results.
Example 2.
---------------------------------------------------
import logging
stream_handler = logging.StreamHandler()
formatter = logging.Formatter('%(asctime)s - %(name)s - %(levelname)s -
%(message)s')
stream_handler.setFormatter(formatter)
app_logger: logging.Logger = logging.getLogger('app')
app_logger.setLevel(logging.ERROR)
app_logger.addHandler(stream_handler)
app_logger.critical('foo')
logging.critical('goo')
app_logger.critical('foo')
---------------------------------------------------
results:
2018-05-04 11:21:15,199 - app - CRITICAL - foo
CRITICAL:root:goo
2018-05-04 11:21:15,200 - app - CRITICAL - foo
CRITICAL:app:foo
---------------------------------------------------
You can see even inconsistency of app_logger`s outputs count.
So I have some proposals for fix it.
Proposal 1.
Remove implicit calling `basicConfig`. Then you can get the consistent results.
Result of the example 1.
foo
goo
foo
Result of the example 2.
2018-05-04 11:31:36,069 - app - CRITICAL - foo
goo
2018-05-04 11:31:36,070 - app - CRITICAL - foo
link :
https://github.com/zsaladin/cpython/commit/c4e789af32da36ba49196fd6be9c070f62346b7a#diff-043d23e54edc5360a7785ae212d1b806
Proposal 2.
Add calling `basicConfig` in `callHandlers` method if the root logger has no
handler.
Result of the example 1.
foo
goo
foo
Result of the example 2.
2018-05-04 11:31:36,069 - app - CRITICAL - foo
goo
2018-05-04 11:31:36,070 - app - CRITICAL - foo
Result of the example 1.
ERROR:app:foo
ERROR:root:goo
ERROR:app:foo
Result of the example 2.
2018-05-04 11:36:45,318 - app - CRITICAL - foo
CRITICAL:app:foo
CRITICAL:root:goo
2018-05-04 11:36:45,319 - app - CRITICAL - foo
CRITICAL:app:foo
https://github.com/zsaladin/cpython/commit/fc295b46a4de584dc5c6724125b2c0f8b2694aa6#diff-043d23e54edc5360a7785ae212d1b806
Thank you.
----------
components: Library (Lib)
messages: 316153
nosy: Daehee Kim
priority: normal
severity: normal
status: open
title: [logging] Improve consistency of logger mechanism.
type: enhancement
versions: Python 3.8
_______________________________________
Python tracker <rep...@bugs.python.org>
<https://bugs.python.org/issue33423>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe:
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
