Stéphane Wirtel <steph...@wirtel.be> added the comment: Hi Hideyuki,
Thank you for your contribution but we need some changes from your PR. 1. Could you add a documentation in Doc/library/ftplib.rst +- line 170, after FTP.set_debuglevel ? 2. There is no tests, please could you add a test in Lib/test/test_ftplib.py 3. Fix the remarks on your PR Thank you ---------- nosy: +matrixise _______________________________________ Python tracker <rep...@bugs.python.org> <https://bugs.python.org/issue32572> _______________________________________ _______________________________________________ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com