Martin Panter <vadmium...@gmail.com> added the comment: Pablo’s code looked unfinished to me. As well as missing documentation, I suspect there may be memory leaks and poor error handling.
The two calls above the “fail:” label look like dead code. The “parse_envlist” result appears to be leaked. I’m curious why you never call “posix_spawn_file_actions_destroy”. I saw on Open BSD <https://man.openbsd.org/posix_spawn_file_actions_init.3> it reclaims memory, and it seems sensible to call it on other platforms as well. No error checking on any of the “posix_spawn_file_actions_” methods. If “posix_spawn” fails, the “pid” variable will be returned uninitialized. ---------- nosy: +martin.panter, pablogsal _______________________________________ Python tracker <rep...@bugs.python.org> <https://bugs.python.org/issue20104> _______________________________________ _______________________________________________ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
