STINNER Victor <victor.stin...@gmail.com> added the comment:
Fix for the two remaining bugs:
diff --git a/Lib/test/test_asyncio/test_base_events.py
b/Lib/test/test_asyncio/test_base_events.py
index 8d72df6a72..6489f50f27 100644
--- a/Lib/test/test_asyncio/test_base_events.py
+++ b/Lib/test/test_asyncio/test_base_events.py
@@ -1917,6 +1917,7 @@ class BaseLoopSendfileTests(test_utils.TestCase):
def test_nonstream_socket(self):
sock = socket.socket(socket.AF_INET, socket.SOCK_DGRAM)
+ sock.setblocking(False)
self.addCleanup(sock.close)
with self.assertRaisesRegex(ValueError, "only SOCK_STREAM type"):
self.run_loop(self.loop.sock_sendfile(sock, self.file))
diff --git a/Lib/test/test_asyncio/test_tasks.py
b/Lib/test/test_asyncio/test_tasks.py
index d2162c31b4..9b62d207e4 100644
--- a/Lib/test/test_asyncio/test_tasks.py
+++ b/Lib/test/test_asyncio/test_tasks.py
@@ -2470,7 +2470,7 @@ class CTask_Future_Tests(test_utils.TestCase):
self.loop = asyncio.new_event_loop()
try:
fut = Fut(loop=self.loop)
- self.loop.call_later(0.1, fut.set_result(1))
+ self.loop.call_later(0.1, fut.set_result, 1)
task = asyncio.Task(coro(), loop=self.loop)
res = self.loop.run_until_complete(task)
finally:
---
Nathaniel: do you want to include these fixes in your PR as well?
Hum, I'm concerned that "self.loop.call_later(0.1, fut.set_result(1))" bug
wasn't spotted previously.
I plan to always run the Python test suite (especially when running on our CIs)
in the new Python 3.7 "development mode" (python3 -X dev) which enables asyncio
debug mode. Are you ok with that?
----------
_______________________________________
Python tracker <rep...@bugs.python.org>
<https://bugs.python.org/issue32636>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe:
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
