Aaron Hall <aaronch...@yahoo.com> added the comment:

So... moving the closure (which may be called recursively) to the global scope 
actually does improve performance (for small cases, about 10% - larger cases 
amortize the cost of the closure being built, but in a 100 item dictionary, 
still about 4% faster to extricate the closure). So I'm reopening. Also 
suggesting we consider doing this with other functions if they are 
unnecessarily closures in the module.

`fix_missing_locations` appears to be another such function with an unnecessary 
closure.

the closure in `dump` cannot be removed without some rewriting of the 
signature, as it uses variables it closes over. Not sure this would be worth it.

----------
resolution: rejected -> 
status: closed -> open

_______________________________________
Python tracker <rep...@bugs.python.org>
<https://bugs.python.org/issue31753>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

Reply via email to