Terry J. Reedy added the comment:
You were waiting on my review of the revised patch.
1. Remove the help_about changes. Reworking help_about is #24813. I just
reviewed Mark Roseman's patch. I do not want the button frames because I would
like to get rid of the buttons. Besides that, I don't think the classes give
enough benefit. If I wanted to keep the buttons, create_py/idle/button
functions might be considered. You can attach to that issue a minimal change
patch or PR that splits off AboutFrame from AboutDialog (the window). Leave
the latter name alone for now to minimize changes needed in other files. We
can then consider adding pieces of what Mark did one at a time.
2. I downloaded the patch, deleted help_about changes, applied, and tested.
Test_help_about needs two insertions of '.textframe' to solve
======================================================================
ERROR: test_file_buttons (idlelib.idle_test.test_help_about.LiveDialogTest)
Test buttons that display files.
----------------------------------------------------------------------
Traceback (most recent call last):
File "f:\dev\3x\lib\idlelib\idle_test\test_help_about.py", line 67, in
test_file_buttons
dialog._current_textview.text.get('1.0', '1.end'))
AttributeError: 'TextviewWindow' object has no attribute 'text'
======================================================================
ERROR: test_printer_buttons (idlelib.idle_test.test_help_about.LiveDialogTest)
Test buttons whose commands use printer function.
----------------------------------------------------------------------
Traceback (most recent call last):
File "f:\dev\3x\lib\idlelib\idle_test\test_help_about.py", line 48, in
test_printer_buttons
dialog._current_textview.text.get('1.0', '1.end'))
AttributeError: 'TextviewWindow' object has no attribute 'text'
Make a PR this time so I can review a side-by-side diff and retest.
----------
_______________________________________
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue30495>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe:
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
