Serhiy Storchaka added the comment: Your PR LGTM. But I think the code can be much simpler.
Here is a patch that shares common code and applies other simplifications to surrounded code. PR 1852 increases the total number of lines by 37 lines, issue30502-simpler.diff -- only by 3 lines. PR 1852: 1 file changed, 49 insertions(+), 12 deletions(-) issue30502-simpler.diff: 1 file changed, 46 insertions(+), 43 deletions(-) ---------- keywords: +patch Added file: http://bugs.python.org/file46909/issue30502-simpler.diff _______________________________________ Python tracker <rep...@bugs.python.org> <http://bugs.python.org/issue30502> _______________________________________ _______________________________________________ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
