New submission from tkhyn:
Hello, I stumbled upon this issue when using the module_has_submodule function
in Django, which raised an exception when trying to import a dotted path such
as ``parent.module`` when ``parent`` does not exist or is not a package. I
would expect (as well as the django devs, apparently) find_spec to return None
instead of raising an AttributeError or ModuleNotFoundError.
Unless you think Django or any package making use of importlib.find_spec should
handle these exceptions, the fix is quite simple.
Steps to reproduce (with Python 3.6.1):
touch parent.py
python3.6
>>> from importlib.util import find_spec
>>> find_spec('parent.module')
File "C:\Python\3.6\Lib\importlib\util.py", line 89, in find_spec
return _find_spec(fullname, parent.__path__)
AttributeError: module 'parent' has no attribute '__path__'
>>> find_spec('invalid_parent.module')
File "C:\Python\3.6\Lib\importlib\util.py", line 88, in find_spec
parent = __import__(parent_name, fromlist=['__path__'])
ModuleNotFoundError: No module named 'invalid_parent'
The fix is quite simple, replacing
if fullname not in sys.modules:
parent_name = fullname.rpartition('.')[0]
if parent_name:
# Use builtins.__import__() in case someone replaced it.
parent = __import__(parent_name, fromlist=['__path__'])
return _find_spec(fullname, parent.__path__)
else:
return _find_spec(fullname, None)
by:
if fullname not in sys.modules:
parent_name = fullname.rpartition('.')[0]
if parent_name:
# Use builtins.__import__() in case someone replaced it.
try:
parent = __import__(parent_name, fromlist=['__path__']).__path__
except (AttributeError, ModuleNotFoundError):
# parent is not a package
return None
else:
parent = None
return _find_spec(fullname, parent)
in importlib.util.find_spec.
----------
components: Library (Lib)
messages: 294209
nosy: tkhyn
priority: normal
severity: normal
status: open
title: importlib.find_spec raises AttributeError/ModuleNotFoundError when
parent is not a package/module
versions: Python 3.6
_______________________________________
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue30436>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe:
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
