Antoine Pitrou <[EMAIL PROTECTED]> added the comment: Bill, I haven't studied your patch in detail but a few comments: - it would be nice to have more unit tests, especially for the various bytes/unicode possibilities, and perhaps also roundtripping (Matt's patch has a lot of tests) - quote_as_bytes() should return a bytes object, not a bytearray - using the "%02X" format looks clearer to me than going through the _hextable lookup table... - when the argument is of the wrong type, quote_as_bytes() should raise a TypeError rather than a ValueError - why is quote_as_string() hardwired to utf8 while unquote_as_string() provides a charset parameter? wouldn't it be better for them to be consistent with each other?
---------- nosy: +pitrou _______________________________________ Python tracker <[EMAIL PROTECTED]> <http://bugs.python.org/issue3300> _______________________________________ _______________________________________________ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
