Oren Milman added the comment: after some closer examination, ISTM that in Objects/exceptions.c, we can't remove PyNumber_Check to optimize or simplify the code, as the argument 'filename' can be either an integer type (only in case the error is a BlockingIOError), or quite anything else, except for None.
We could replace PyNumber_Check(filename) with PyIndex_Check(filename), but this would change the behavior of BlockingIOError. IMHO, this isn't that important, and thus we should leave the code in Objects/exceptions.c as is. anyway, I would soon create a pull request to remove all other aforementioned calls to PyNumber_Check. ---------- _______________________________________ Python tracker <rep...@bugs.python.org> <http://bugs.python.org/issue29730> _______________________________________ _______________________________________________ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
