Marc-Andre Lemburg added the comment: On 14.02.2017 11:16, STINNER Victor wrote: > >> Please note that the two sets of APIs are not identical, e.g. you cannot >> simply replace PyEval_CallObject() with PyObject_Call(), since the former >> applies a few extra checks and defaults, which the latter doesn't. > > IMHO these checks are too expensive at runtime for little benefit. If you > pass non-tuple to PyObject_Call(), Python immediately crash. You are > immediately noticied of the bug :-) I don't think that such bugs are common > enough to justify the overhead.
>From the design of the abstract API layer, it is rather uncommon to have these not do extra checks to prevent segfaults. They were originally designed to be safe and developer friendly. OTOH, the PyEval_* APIs were designed to be fast, only for people who know what they are doing and for interpreter internals. Historically, this design approach appears to have been swapped somewhere between Python 2.1 and 2.2 for the call APIs, which is unfortunate. So from a design perspective, it would be better to have the abstract APIs again do proper checks and leave the low level, "segfault protected" :-) call APIs around as PyEval_Call*() or better yet: not make them public at all. > Any idea of the popularity of the undocumented PyEval_xxx() functions? Are > they used by Cython for example? By a single random extension module in the > world? Well, I know that our eGenix extensions are using them and there are quite a few hits on github as well: https://github.com/search?utf8=%E2%9C%93&q=PyEval_CallObjectWithKeywords&type=Code&ref=searchresults > I'm more in favor of modifying PyEval_xxx() to call PyObject_xxx() and > deprecate them. ---------- _______________________________________ Python tracker <rep...@bugs.python.org> <http://bugs.python.org/issue29548> _______________________________________ _______________________________________________ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
