kumaar.nd added the comment: hi, I reviewed the changes of patch set-2. In the test_regrtest.py, instead of adding new condition 229:self.checkError([opt, '0', '-T'], "don't go together") 230:self.checkError([opt, '0', '-l'], "don't go together") isnt it easier to just tweak and replace the existing 227:self.checkError([opt, '2', '-T'], "don't go together") 228:self.checkError([opt, '2', '-l'], "don't go together") with teh above changes?
If the suggestion sound naive, this is my first developer review and am new to python too. ---------- nosy: +kumaar.nd _______________________________________ Python tracker <rep...@bugs.python.org> <http://bugs.python.org/issue28950> _______________________________________ _______________________________________________ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
