STINNER Victor added the comment: I pushed a change which is rename.patch with fixes on comments in abstract.h. It seems like comments were no more revelant or moved to random places. I moved many comments, rewrote some of them, etc. Some comments were wrong like "This is the equivalent of the Python expression: o.method(args)", it's "o.method(*args)" in fact. Serhiy catched this mistake, it should now be fixed.
I chose to push this large change, instead of having another round of review, because it's tricky to handle such large changes. I suggest to push following changes if you still see issues. I also wanted to push it quickly because I have pending changes modifying the same parts of the code in my queue :-) Thanks for reviews Serhiy! Very useful, as usual ;-) Serhiy: "I think we can keep "func" instead of "callable" in the source code for decreasing the number of changes." I prefer to "fix" it as well, the purpose of the issue is to uniformize everything: .c files, .h files and .rst documentation. ---------- _______________________________________ Python tracker <rep...@bugs.python.org> <http://bugs.python.org/issue28838> _______________________________________ _______________________________________________ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
