STINNER Victor added the comment: issue28754-4.diff does 3 things: * convert C code to Argument Clinic * change docstrings of the C code * change unit tests
issue28754-5.diff doesn't touch tests, but still does 2 things. Sadly, I dislike the changes on docstrings because it makes the C docstring and the Python docstring inconsistent. I suggest to copy/paste docstring between C and Python code. By the way, why do we have a docstring different from Doc/library/bisect.rst? Maybe we can simply use the same doc everywhere, but just add reST formatting in Doc/library/bisect.rst? Julien: I suggest to first restrict your change to Argument Clinic, and later write a new patch to update docstrings. I prefer to only do one thing per commit. ---------- _______________________________________ Python tracker <rep...@bugs.python.org> <http://bugs.python.org/issue28754> _______________________________________ _______________________________________________ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
