Xavier de Gaye added the comment: New patch taking into account Martin last review and some updated comments.
>> Why do you remove the code that loops over Modules/Setup? Maybe is it >> redundant with the other code for removing the already-built-in modules? > Yes because this is redundant, maybe not the case when this was written 15 > years ago. * sys.builtin_module_names are the modules listed in the _PyImport_Inittab[] array that is built by Modules/makesetup from Modules/config.c.in and the '*static*' modules configured in the Setup files (those Setup files that are listed in the rule of the 'Makefile' target of the Makefile). This list is missing the '*shared*' modules configured in the Setup files and that should not be built by setup.py. * The setup.py code that loops over and loosely parses some of the Modules/Setup files, excludes both '*static*' and '*shared*' modules from the built modules. * 'MODNAMES' does the same thing in the patch accurately as the list is built by makesetup. New issue 28542 to document the cross-compilation. ---------- Added file: http://bugs.python.org/file45239/removed_modules_3.patch _______________________________________ Python tracker <rep...@bugs.python.org> <http://bugs.python.org/issue28444> _______________________________________ _______________________________________________ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
