New submission from Mark Dickinson: The newly-added statistics.geometric_mean function appears to have no tests at all, with the exception of a single doctest:
>>> geometric_mean([1.10, 0.95, 1.12]) 1.0538483123382172 Steve, Ned: what do you think about taking geometric_mean out of Python 3.6, leaving us time to get it into shape for 3.7? The implementation of geometric_mean is complicated, with many edge cases. The original code was committed without review in #27181, and it currently suffers from some serious bugs: see #27761, #28111, #28327 (the first of these affects only the tests for nroot; the second and third are behaviour bugs in geometric_mean). With the lack of tests, and Python 3.6 b2 looming, I think the best thing to do might be to defer the inclusion of geometric_mean to Python 3.7. I'll mark this as a release blocker until we decide what to do. ---------- assignee: steven.daprano messages: 277811 nosy: mark.dickinson, ned.deily, steven.daprano priority: release blocker severity: normal stage: test needed status: open title: statistics.geometric_mean has no tests. Defer to 3.7? type: behavior versions: Python 3.6, Python 3.7 _______________________________________ Python tracker <rep...@bugs.python.org> <http://bugs.python.org/issue28328> _______________________________________ _______________________________________________ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com