Ammar Askar added the comment:

>The latter. All of the popular browsers (Chrome, Firefox, Edge and even 
>Safari) already support the placeholder attribute so I think we can safely 
>ignore IE 8 :)

Roger, I've changed it to placeholder.


>I know this is basically a copy of upstream searchbox.html, but we can 
>probably remove ``style="display: none"`` and ``$('.inline-search').show(0);``.

The reason that exists is because sphinx's search relies on javascript.


>inline-search doesn't seem to be necessary here. ``display: inline`` is 
>already applied by ``div.related li``.

Good catch, I've removed the class from there.

----------
Added file: http://bugs.python.org/file44509/searchbar_in_header.diff4

_______________________________________
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue19489>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

Reply via email to