New submission from Ondřej Medek:
The logging.getLevelName contains code:
return _levelToName.get(level, _nameToLevel.get(level, ("Level %s" % level)))
I am still a Python beginner, but I think the most of the times the
_nameToLevel.get is called unnecessarily. IMHO the code should be
return _levelToName.get(level, (_nameToLevel.get(level, ("Level %s" % level))))
or maybe better a classic if then style:
result = _levelToName.get(level)
if result is None:
result = _nameToLevel.get(level, ("Level %s" % level))
return result
Since this function is called every time the LogRecord is created, I think it
should be microoptimized.
----------
components: Library (Lib)
messages: 274210
nosy: Ondřej Medek
priority: normal
severity: normal
status: open
title: logging.getLevelName microoptimization
type: performance
versions: Python 3.5
_______________________________________
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue27937>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe:
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
