Berker Peksag added the comment:
I don't understand the second part of the patch.
*filename* is a filesystem encoding (:func:`os.fsdecode`) encoded string
[...]
Do you want to document that filename should be encoded by using
PyUnicode_EncodeFSDefault *before* passing it to Py_CompileStringExFlags (you
will probably need to wrap it with something like PyBytes_AsString too)? If so,
I think the os.fsdecode() part needs to be changed to os.fsencode().
I think the current wording is saying that filename is going to be decoded
inside of Py_CompileStringExFlags (which is also correct.)
----------
nosy: +berker.peksag, haypo
stage: -> patch review
versions: +Python 3.5
_______________________________________
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue27740>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe:
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
