Martin Panter added the comment:

Yes I agree it would make sense to separate the test_httplib changes from the 
general change. I thought this task would be a very easy change, and noticed it 
wasn’t that simple the last minute.

I would like to adjust the cleanup call to

self.addCleanup(thread.join, float(1))

That should be a better equivalent to what @reap_threads does. Or I can just 
use @reap_threads directly on test_response_fileno(), if people prefer.

----------

_______________________________________
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue27787>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

Reply via email to