Xavier Combelle added the comment: I made some comment on code in review.
A thing that worry me that there is zero automated test. In my opinion the minimal should be to test the expected output. A nice to have would be a test for the write_contents function of makeopcodetranslations.py ---------- nosy: +xcombelle _______________________________________ Python tracker <rep...@bugs.python.org> <http://bugs.python.org/issue25571> _______________________________________ _______________________________________________ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
