Martin Panter added the comment:

I still think the links are too dense. Three links to the same term in two 
short paragraphs is too much. Do you think it would be okay to just link the 
first occurrence for pkgutil.ImpImporter?

Also, there is still a problem at least the definition of “finder” used by the 
ImpImporter documentation. In PEP 302, “a finder object has a single method: 
finder.find_module(fullname, path=None)”. This seems to be a pretty good 
description of the ImpImporter API. However, by dropping the reference to PEP 
302, and linking to the glossary definition, we are suggesting that ImpImporter 
implements importlib.abc.MetaPathFinder and/or importlib.abc.PathEntryFinder. 
Both these APIs require some sort of find_spec() method, which is not provided 
by ImpImporter.

As I see it, either Python’s “finder” glossary entry should be adjusted to 
accommodate PEP 302, or we should retain the PEP 302 reference and not point at 
the wrong definition of “finder”.

----------

_______________________________________
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue20842>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

Reply via email to