Berker Peksag added the comment: Thanks for the patch Alex. Some quick review comments:
* We need to skip SqliteOnConflictTests if the installed sqlite3 doesn't support the feature * There is no need to duplicate https://www.sqlite.org/lang_conflict.html in every test. You can add it to SqliteOnConflictTests docstring. * Instead of ``try: <something> except sqlite.IntegrityError: <pass>`` we can make sure that sqlite.IntegrityError is raised by using assertRaises (like you did in CheckOnConflictFail.) * The following pattern can be replaced with a list comprehension: + returned_rows = [] + for row in self.cu: + returned_rows.append(row) ---------- nosy: +berker.peksag stage: needs patch -> patch review versions: +Python 3.6 -Python 2.7, Python 3.4 _______________________________________ Python tracker <rep...@bugs.python.org> <http://bugs.python.org/issue21250> _______________________________________ _______________________________________________ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
