Hirokazu Yamamoto <[EMAIL PROTECTED]> added the comment:

Thank you for progress!

>- The patch for 2.5 is OK for me. We could just add the a paragraph that
>appears in your patch for trunk (PC/VC6/readme.txt):
>+_msi
>+    _msi.c. You need to install Windows Installer SDK to build this
>module.

I agree.

>- I worked on your patch for trunk/ and py3k/ to allow compilation with
>a stock VC6 *without* a modern PlatformSDK installed (i.e NTDDI_VERSION
>is not defined)
>This is relevant only for socketmodule; with a stock VC6, IPV6 is not
>available, WSAIoctl is not exposed, and getaddrinfo() is emulated.

I'm not sure which is better way now. (with or without modern PSDK)
From cleaness of code, I think with modern PSDK is better.
http://archives.devshed.com/forums/development-94/error-building-python-bindings-with-ms-visual-c-6-0t-2074150.html
show subversion already seems to require modern PSDK to build it, if 
python uses modern PSDK and winsock2, workaround for socklen_t is not
needed anymore. clean. (this workaround itself is quite easy though)
Of cause, Amaury wants to go without modern PSDK, there is no strong
reason I will disturb it.

>- Replacing _wstat with GetFileAttributesW is good thing: stat("nul")
>says that the file exists!
>But it is not enough: try to "import con" or "import nul", before and
>after your patch. Fun in both cases (if you "import con", type some
>chars, and press ^Z)

Interesting. Current release25-maint branch has same issue, but
python2.5.2 doesn't have this issue. "import con" fails with following
message. Something changed from latest release?

>>> import con
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
ImportError: DLL load failed: 指定されたモジュールが見つかりません。

# It says "specified module cannot be found" in Japanese. Maybe is this
win32 error message via FormatMessage()?

_______________________________________
Python tracker <[EMAIL PROTECTED]>
<http://bugs.python.org/issue2065>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

Reply via email to