Benjamin Peterson <[EMAIL PROTECTED]> added the comment: On Mon, Jun 9, 2008 at 8:40 AM, Simon Cross <[EMAIL PROTECTED]> wrote: > > Simon Cross <[EMAIL PROTECTED]> added the comment: > > One of the examples Christoph tried was > > unicode(Exception(u'\xe1')) > > which fails quite oddly with: > > UnicodeEncodeError: 'ascii' codec can't encode character u'\xe1' in > position 0: ordinal not in range(128) > > The reason for this is Exception lacks an __unicode__ method > implementation so that unicode(e) does something like unicode(str(e)) > which attempts to convert the exception arguments to the default > encoding (almost always ASCII) and fails.
What version are you using? In Py3k, str is unicode so __str__ can return a unicode string. > > Fixing this seems quite important. It's common to want to raise errors > with non-ASCII characters (e.g. when the data which caused the error > contains such characters). Usually the code raising the error has no way > of knowing how the characters should be encoded (exceptions can end up > being written to log files, displayed in web interfaces, that sort of > thing). This means raising exceptions with unicode messages. Using > unicode(e.message) is unattractive since it won't work in 3.0 and also > does not duplicate str(e)'s handling of the other exception __init__ > arguments. > > I'm attaching a patch which implements __unicode__ for BaseException. > Because of the lack of a tp_unicode slot to mirror tp_str slot, this > breaks the test that calls unicode(Exception). The existing test for > unicode(e) does unicode(Exception(u"Foo")) which is a bit of a non-test. > My patch adds a test of unicode(Exception(u'\xe1')) which fails without > the patch. > > A quick look through trunk suggests implementing tp_unicode actually > wouldn't be a huge job. My worry is that this would constitute a change > to the C API for PyObjects and has little chance of acceptance into 2.6 > (and in 3.0 all these issues disappear anyway). If there is some chance > of acceptance, I'm willing to write a patch that adds tp_unicode. Email Python-dev for permission. _______________________________________ Python tracker <[EMAIL PROTECTED]> <http://bugs.python.org/issue2517> _______________________________________ _______________________________________________ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
